Wireshark-bugs: [Wireshark-bugs] [Bug 4014] ICMP: Add ID and seq # to Info column
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4014
Chris Maynard <christopher.maynard@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4796| |review_for_checkin?
Flag| |
--- Comment #14 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-06-17 09:41:12 PDT ---
Created an attachment (id=4796)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4796)
Patch to try to clean up seq # BE/LE "messyness".
Stig, have a look at the attached patch. It attempts to use heuristics to
determine the seq # byte ordering based on the ID field. It assumes that all
versions of Windows will use an ID < 10 (I have seen only 2, 3 or 4 with
Windows XP), and also that they will always use a little-endian seq #. I am
unable to test this with other versions of Windows besides XP, so I don't know
if this is still true or will always be the case. But assuming these
heuristics do work, then it avoids the messy BE/LE thing in the Info column
w/out adding any additional ICMP preferences for seq # byte ordering (which
arguably could also be considered messy).
The motivation in using heuristics rather than setting the endian-ness by a
preference setting is that the dissector is able to properly display the
sequence #'s in either LE or BE format as the case may be, illustrated in the
soon-to-be attached capture file ...
Of course if these heuristics are not robust enough (say if the case is that
Windows 7 turns out to have fixed their incorrect byte ordering of the ICMP
fields), then we might need to add a preference after all.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
