Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 2631] B.A.T.M.A.N. Advanced dissector

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2631

Gerald Combs <gerald@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #60 from Gerald Combs <gerald@xxxxxxxxxxxxx> 2010-06-02 16:03:38 PDT ---
The recursion that Stig pointed out in comment 47 is still there. Instead of
having dissect_batadv_batman_v{5,7,9} call themselves, dissect_batadv_batman
should probably loop over the tvbuff:

static void dissect_batadv_batman(tvbuff_t *tvb, packet_info *pinfo, proto_tree
*tree)
{

    [ ... ]

    case 7:
    case 8:
            while (there's still tvb data...) {
        offset = dissect_batadv_batman_v7(tvb, offset, pinfo, tree);
        break;
            }

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.