Wireshark-bugs: [Wireshark-bugs] [Bug 4826] Buildbot crash output: fuzz-2010-06-02-11020.pcap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 2 Jun 2010 13:31:06 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4826

--- Comment #3 from Guy Harris <guy@xxxxxxxxxxxx> 2010-06-02 13:31:05 PDT ---
I'm not sure what

   Note that the number of UDVM cycles MUST NOT be increased if a
   request for additional compressed data fails.

means - I sure hope it doesn't mean that any instruction that makes a failed
request for additional compressed data doesn't increase the UDVM cycle count at
all.  It probably refers only to the UDVM cycle increase from

   Additionally, if the UDVM successfully requests n bits of compressed data
using one of the INPUT instructions then the number of available UDVM cycles is
  increased by n * cycles_per_bit once the instruction has been executed.

The cycle-counting stuff in sigcomp-udvm.c is bumping the cycle count at
different points for different instructions.  My inclination would be to make
your change as the first step and then do all the cycle count increases for the
instructions from the table as soon as the relevant operand is fetched.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.