Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 4814] Feature Request: ISO/IEC 13818-1 over USB support

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4814

Chris Maynard <christopher.maynard@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4729|                            |review_for_checkin?
               Flag|                            |

--- Comment #5 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-06-02 12:56:27 PDT ---
Created an attachment (id=4729)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4729)
Patch so both PPP and ISO/IEC 13818-1 over USB are dissected using heuristics.

Well, there is already an mp2t dissector, but when I tried adding
"dissector_add("usb.bulk", IF_CLASS_UNKNOWN, mp2t_handle);" to the
proto_reg_handoff_mp2t() routine, the applicable packets still weren't
dissected.  Only after I pulled out that same dissector_add() call from
packet-ppp.c's handoff routine did it work ... but then of course none of the
ppp packets were dissected.

So ... I'm not entirely sure how best to fix this.  The attached patch uses
heuristics and appears to work fine, but I don't know if this is the best way
to do this or not.  Anyone more intimately familiar with the USB dissector who
could offer a better patch?  I don't see any inherent harm in this patch; I
just get the feeling that there's a better way.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.