Wireshark-bugs: [Wireshark-bugs] [Bug 4810] PPP/USB dissector should probably register on IF_CLA
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 30 May 2010 12:39:55 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4810

Chris Maynard <christopher.maynard@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4709|                            |review_for_checkin?
               Flag|                            |

--- Comment #1 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-05-30 12:39:54 PDT ---
Created an attachment (id=4709)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4709)
Patch so PPP/USB dissector registers for IF_CLASS_CDC_DATA

I guess it was inevitable.  As I commented in bug 4722, there are 19 IF_CLASS's
defined in packet-usb.h.  I didn't want to register for all of them because I
don't know if they're all applicable, and I also have no way to test them all.

Anyway, this trivial patch registers for IF_CLASS_CDC_DATA, leaving 16 others
not yet registered.  I'm still inclined just to add them as needed, but if one
of the core developers thinks it's better just to register for all of them,
then we can do that too.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.