Wireshark-bugs: [Wireshark-bugs] [Bug 3161] text2pcap.c define trickery breaks strdup() handling
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 18 May 2010 10:00:06 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3161

--- Comment #15 from Petr Sumbera <petr.sumbera@xxxxxxx> 2010-05-18 10:00:02 PDT ---
(In reply to comment #14)
> (In reply to comment #13)
> > Also when compiling the module with Sun Studio without "-xc99=all" it went
> > fine..
> 
> How did that get there?  My understanding is Wireshark is targeted at C89 and
> we specifically should not be using any C99 features so does it really make
> sense to use this flag?

Well, we try to build FOSS applications with this option by default in Solaris
(sfw gate).
But I can now confirm that without this option Wireshark 1.3.5 will build fine.
(I have vague feeling that in past some Wireshark module required C99 mode)

So in general Wireshark has no problem with C99 but this one.. It's little bit
pity. But if Wiresahrk is really targeted for C89 we can maybe close this bug
then..

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.