Wireshark-bugs: [Wireshark-bugs] [Bug 4764] New Protocol Submission for IEEE 1722(AVB Transport
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 14 May 2010 11:49:49 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4764

--- Comment #3 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-05-14 14:49:48 EDT ---
Comments:

1. It appears that you could get a 'divide by 0' trap in the following
   if dbs has a garbage value in the capture file.

        dbs = tvb_get_guint8(tvb, IEEE_1722_DBS_OFFSET);

        /* Loop through all samples and add them to the audio tree. */
        for (j = 0; j < (datalen / (dbs*4)); j++) {

2. "" in hf[] "blurb" should be NULL.

3. Re:    ... = proto_register_protocol("IEEE 1722 Protocol", "IEEE1722",
"1722");

   The convention appears to be to either use ieee1722 for the
'protocol-abbreviation" (and the filter names in the hf[] array).

So: what would you think about using ieee1722 or avbtp  ??

4. [There are a few tabs in the file].

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.