Wireshark-bugs: [Wireshark-bugs] [Bug 4745] Add Ratified DMX to ACN Dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 5 May 2010 07:21:13 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4745

--- Comment #4 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2010-05-05 16:21:11 CEST ---
(In reply to comment #3)
> (In reply to comment #2)
> > I was about to ask: what's the rationale for the change in is_acn() ?
> 
> Before the change, is_acn() was returning FALSE when it should have returned
> TRUE (for packets that contained "ASC-E1.17\0\0\0"). tvb_memeql was returning
> TRUE.

Indeed, because sizeof(acn_packet_id) is 13, not 12 as was assumed. This only
worked if the following byte was 0x00 also.
So the (real) fix is rather easy: replace sizeof() or subtract one.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.