Wireshark-bugs: [Wireshark-bugs] [Bug 4694] New: Another bug in packet-gtp.c (mask of Signalling
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 18 Apr 2010 20:32:07 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4694

           Summary: Another bug in packet-gtp.c (mask of Signalling
                    Indication)
           Product: Wireshark
           Version: 1.2.6
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: tamas.regos@xxxxxxxxxxxx


Created an attachment (id=4539)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4539)
Qos Profile mask corrections

Build Information:
Version 1.2.6 (SVN Rev 31702)

Copyright 1998-2010 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.18.5, with GLib 2.22.3, with WinPcap (version unknown),
with libz 1.2.3, without POSIX capabilities, without libpcre, with SMI 0.4.8,
with c-ares 1.7.0, with Lua 5.1, with GnuTLS 2.8.5, with Gcrypt 1.4.5, with MIT
Kerberos, with GeoIP, with PortAudio V19-devel (built Jan 27 2010), with
AirPcap.

Running on 32-bit Windows Vista Service Pack 1, build 6001, with WinPcap
version
4.1.1 (packet.dll version 4.1.0.1753), based on libpcap version 1.0 branch
1_0_rel0b (20091008), GnuTLS 2.8.5, Gcrypt 1.4.5, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
After 'Bug 4677 - harmless typo and whitespace bugs in packet-gtp.c', I
continued the code analysis for QoS Profile.

Signalling Indication bit can be found in octet 14 of QoS Profile (if exists).
Based on TS 24.008 V 7.8.0:
Signalling Indication, octet 14 (see 3GPP TS 23.107) Bit 5

In the code we have mask 0x01 but it is wrong because it should be 0x10 for bit
5.

sig_ind = wrapped_tvb_get_guint8(tvb, offset + (12 - 1) * utf8_type + 1,
utf8_type)& 0x01; <---

Instead of correcting this one bug only, I thought it would be better to use
the predefined QoS masks to avoid similar situations. And I added 2 more masks
because they were missing. I'm not sure everybody agrees but it seems much more
readable for me.

So the patch contains the mask changes for QoS Profile plus accidentally some
changes of Bug 4677 were missing.

The patch is based on packet-gtp.c rev 32474.

Regards,
Tamas

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.