Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 4677] New: harmless typo and whitespace bugs in packet-gtp.c

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4677

           Summary: harmless typo and whitespace bugs in packet-gtp.c
           Product: Wireshark
           Version: 1.2.6
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: tamas.regos@xxxxxxxxxxxx


Build Information:
Version 1.2.6 (SVN Rev 31702)

Copyright 1998-2010 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.18.5, with GLib 2.22.3, with WinPcap (version unknown),
with libz 1.2.3, without POSIX capabilities, without libpcre, with SMI 0.4.8,
with c-ares 1.7.0, with Lua 5.1, with GnuTLS 2.8.5, with Gcrypt 1.4.5, with MIT
Kerberos, with GeoIP, with PortAudio V19-devel (built Jan 27 2010), with
AirPcap.

Running on 32-bit Windows Vista Service Pack 1, build 6001, with WinPcap
version
4.1.1 (packet.dll version 4.1.0.1753), based on libpcap version 1.0 branch
1_0_rel0b (20091008), GnuTLS 2.8.5, Gcrypt 1.4.5, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
These are some harmless typo and whitespace faults.


1. gtp.qos_reliabilty <--> gtp.qos_reliability

function void proto_register_gtp(void)
In static hf_register_info hf_gtp[]

{"QoS reliability", "gtp.qos_reliabilty", FT_UINT8, BASE_DEC,
VALS(qos_reliability_type), GTP_EXT_QOS_RELIABILITY_MASK,
      "Quality of Service Reliability Class", HFILL}}, 


2. octet 13 <--> octet 12
Uplink is related to octet 12, downlink is related to octet 13.
Probably here the author just did a copy+paste...

/* Octet 18 */
if(guar_ul_ext == 0) 
    proto_tree_add_text(ext_tree_qos, tvb, offset + (16 - 1) * utf8_type + 1,
utf8_type, "Use the value indicated by the Guaranteed bit rate for uplink in
octet 13");


3. extra whitespace in front of the colon.

for uplink : <--> for uplink:
for downlink : <--> for downlink:
size : <--> size:


proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_max_sdu_size, tvb, offset +
(5 - 1) * utf8_type + 1, utf8_type, mss,"Maximum SDU size : %u octets", mss);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_max_ul, tvb, offset + (6 -
1) * utf8_type + 1, utf8_type, max_ul,"Maximum bit rate for uplink : %u kbps",
max_ul);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_max_ul, tvb, offset + (6 -
1) * utf8_type + 1, utf8_type, mu,"Maximum bit rate for uplink : %u kbps", mu);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_max_ul, tvb, offset + (6 -
1) * utf8_type + 1, utf8_type, mu,"Maximum bit rate for uplink : %u kbps", mu);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_max_dl, tvb, offset + (7 -
1) * utf8_type + 1, utf8_type, max_dl,"Maximum bit rate for downlink : %u
kbps", max_dl);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_max_dl, tvb, offset + (7 -
1) * utf8_type + 1, utf8_type, md,"Maximum bit rate for downlink : %u kbps",
md);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_max_dl, tvb, offset + (7 -
1) * utf8_type + 1, utf8_type, md,"Maximum bit rate for downlink : %u kbps",
md);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_guar_ul, tvb, offset + (10
- 1) * utf8_type + 1, utf8_type, guar_ul,"Guaranteed bit rate for uplink : %u
kbps", guar_ul);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_guar_ul, tvb, offset + (10
- 1) * utf8_type + 1, utf8_type, gu,"Guaranteed bit rate for uplink : %u kbps",
gu);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_guar_ul, tvb, offset + (10
- 1) * utf8_type + 1, utf8_type, gu,"Guaranteed bit rate for uplink : %u kbps",
gu);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_guar_dl, tvb, offset + (11
- 1) * utf8_type + 1, utf8_type, guar_dl,"Guaranteed bit rate for downlink : %u
kbps", guar_dl);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_guar_dl, tvb, offset + (11
- 1) * utf8_type + 1, utf8_type, gd,"Guaranteed bit rate for downlink : %u
kbps", gd);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_guar_dl, tvb, offset + (11
- 1) * utf8_type + 1, utf8_type, gd,"Guaranteed bit rate for downlink : %u
kbps", gd);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_max_dl, tvb, offset + (13 -
1) * utf8_type + 1, utf8_type, md,"Ext Maximum bit rate for downlink : %u
kbps", md);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_max_dl, tvb, offset + (13 -
1) * utf8_type + 1, utf8_type, md,"Ext Maximum bit rate for downlink : %u
Mbps", md);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_max_dl, tvb, offset + (13 -
1) * utf8_type + 1, utf8_type, md,"Ext Maximum bit rate for downlink : %u
Mbps", md);
proto_tree_add_text(ext_tree_qos, tvb, offset + (14 - 1) * utf8_type + 1,
utf8_type, "Use the value indicated by the Guaranteed bit rate for downlink in
octet 13");
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_guar_dl, tvb, offset + (14
- 1) * utf8_type + 1, utf8_type, gd,"Ext Guaranteed bit rate for downlink : %u
kbps", gd);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_guar_dl, tvb, offset + (14
- 1) * utf8_type + 1, utf8_type, gd,"Ext Guaranteed bit rate for downlink : %u
Mbps", gd);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_guar_dl, tvb, offset + (14
- 1) * utf8_type + 1, utf8_type, gd,"Ext Guaranteed bit rate for downlink : %u
Mbps", gd);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_max_ul, tvb, offset + (15 -
1) * utf8_type + 1, utf8_type, md,"Ext Maximum bit rate for uplink : %u kbps",
md);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_max_ul, tvb, offset + (15 -
1) * utf8_type + 1, utf8_type, md,"Ext Maximum bit rate for uplink : %u Mbps",
md);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_max_ul, tvb, offset + (15 -
1) * utf8_type + 1, utf8_type, md,"Ext Maximum bit rate for uplink : %u Mbps",
md);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_guar_ul, tvb, offset + (16
- 1) * utf8_type + 1, utf8_type, gd,"Ext Guaranteed bit rate for uplink : %u
kbps", gd);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_guar_ul, tvb, offset + (16
- 1) * utf8_type + 1, utf8_type, gd,"Ext Guaranteed bit rate for uplink : %u
Mbps", gd);
proto_tree_add_uint_format(ext_tree_qos, hf_gtp_qos_guar_ul, tvb, offset + (16
- 1) * utf8_type + 1, utf8_type, gd,"Ext Guaranteed bit rate for uplink : %u
Mbps", gd);

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.