Wireshark-bugs: [Wireshark-bugs] [Bug 4283] add vendor extension support for 802.11 radiotap hea
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4283
Johannes Berg <johannes@xxxxxxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |johannes@xxxxxxxxxxxxxxxx
--- Comment #8 from Johannes Berg <johannes@xxxxxxxxxxxxxxxx> 2010-03-30 13:50:17 PDT ---
What a shortsighted decision to commit this instead of my patch, I'm very
disappointed.
If you didn't like the fact that I replaced the parser wholesale, you could've
asked for a proper solution in the other bug. Fact is that the argument about
the patch being ready before the agreement was made are completely bogus since
the radiotap standardisation started out with both being defined properly.
Also, this patch is simply WRONG according to how the vendor namespace was
defined, and it does not handle multiple vendor extensions properly, and
similar.
+#define MAX_PRESENT 2
for instance is already completely wrong according to the radiotap standard
even without the vendor extensions. This patch helps nothing, wireshark is
still unable to dissect completely legal radiotap headers.
Please revert this patch and apply mine instead to fix the mess.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
