Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 4609] tcp.options.sack_perm not being used as a field

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4609

--- Comment #1 from Martin Visser <martinvisser99@xxxxxxxxx> 2010-03-23 06:41:31 PDT ---
Hi, I have had a bit of read through the code, and come up with a patch that I
have built and tested on Linux (Ubuntu using WS 1.2.6 base).

--- packet-tcp.c    2010-03-23 06:36:44.865686812 -0700
+++ packet-tcp-fix-sack_perm.mv.c    2010-03-23 06:20:33.501483019 -0700
@@ -2135,6 +2135,17 @@
     col_append_fstr(pinfo->cinfo, COL_INFO, " %s[%s]", abbrev, val);
 }

+
+static void
+dissect_tcpopt_sack_perm(const ip_tcp_opt *optp, tvbuff_t *tvb,
+    int offset, guint optlen, packet_info *pinfo, proto_tree *opt_tree)
+{
+  proto_item *hidden_item;
+  hidden_item = proto_tree_add_boolean(opt_tree, hf_tcp_option_sack_perm, tvb,
offset,
+                optlen, TRUE);
+  tcp_info_append_uint(pinfo, "SACK_PERM", TRUE);
+}
+
 static void
 dissect_tcpopt_maxseg(const ip_tcp_opt *optp, tvbuff_t *tvb,
     int offset, guint optlen, packet_info *pinfo, proto_tree *opt_tree)
@@ -2644,7 +2655,7 @@
     NULL,
     FIXED_LENGTH,
     TCPOLEN_SACK_PERM,
-    NULL,
+    dissect_tcpopt_sack_perm,
   },
   {
     TCPOPT_SACK,
@@ -3913,7 +3924,7 @@
             HFILL}},

         { &hf_tcp_option_sack_perm,
-          { "TCP Sack Perm Option", "tcp.options.sack_perm",
+          { "SACK permitted", "tcp.options.sack_perm",
             FT_BOOLEAN,
             BASE_NONE, NULL, 0x0, "TCP Sack Perm Option", HFILL}},

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.