Wireshark-bugs: [Wireshark-bugs] [Bug 4481] Update x11 dissector to support new XCB features
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4481
--- Comment #2 from Peter Harris <peter.harris@xxxxxxxxxxxxxxx> 2010-03-22 09:07:13 PDT ---
(In reply to comment #1)
> I doubt it's related to this patch, but after applying and updating the git
> repositories, I get:
>
> -#include "x11-glx-render-enum.h"
>
> Should that include file now be removed?
No. It looks like you regenerated the dissector without mesa (== GLX extension
support).
Awww, nuts. Looks like the mesa guys rearranged their repo. I'll work on a
patch to detect the new API definition location.
(February 22, commit f437a6737 in case you were wondering why I didn't notice
that before I sent this patch on February 10)
> It ends up a huge diff which means it
> may take a while to review:
Using an older mesa, my diffstat is similar, although it doesn't contain most
of the lines deleted:
epan/dissectors/packet-x11.c | 14
epan/dissectors/x11-declarations.h | 2821 +++++++++
epan/dissectors/x11-enum.h | 208
epan/dissectors/x11-extension-errors.h | 11
epan/dissectors/x11-extension-implementation.h | 7743
++++++++++++++++++++++++-
epan/dissectors/x11-glx-render-enum.h | 7
epan/dissectors/x11-register-info.h | 2821 +++++++++
tools/process-x11-xcb.pl | 323 -
8 files changed, 13809 insertions(+), 139 deletions(-)
(using xcbproto version 1.6-3-g3c75db3 and using mesa version
mesa_7_6_1_rc1-3328-gaeb34b2 -- "git checkout aeb34b2" in the mesa dir to
reproduce this state)
The point of generating all of this automatically from upstream protocol
descriptions is so you don't have to review every single line. The X11 protocol
isn't small, and it isn't shrinking.
The manual changes amount to:
epan/dissectors/packet-x11.c | 14 +
tools/process-x11-xcb.pl | 323
++++++++++++++++++++++++++++---------------
2 files changed, 228 insertions(+), 109 deletions(-)
Which should be a lot easier to review, in theory.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
