Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 4588] Decoding of 3 digit MNC value appears to be broken in dissect_e212_mcc_m

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4588

Anders Broman <anders.broman@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anders.broman@xxxxxxxxxxxx

--- Comment #1 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2010-03-19 05:50:40 PDT ---
As noted the MNC is encoded different in different IE's. I think
dissect_e212_mcc_mnc() may have to be split in two functions
depending on the format.
The following occurrences must be cross checked with the protocol description
and the apropriate function used.

packet-bssap.c: dissect_e212_mcc_mnc(tvb, pinfo, plmn_tree, offset);  
packet-diameter_3gpp.c: offset = dissect_e212_mcc_mnc(tvb, pinfo, sub_tree,
offset);
packet-e212.c:dissect_e212_mcc_mnc(tvbuff_t *tvb, packet_info *pinfo,
proto_tree *tree, int offset){
packet-e212.c:dissect_e212_mcc_mnc_in_address(tvbuff_t *tvb, packet_info
*pinfo, proto_tree *tree, int offset)
packet-gsm_a_bssmap.c:          curr_offset = dissect_e212_mcc_mnc(tvb,
g_pinfo, tree, curr_offset);          
packet-gsm_a_common.c:  curr_offset = dissect_e212_mcc_mnc(tvb,
gsm_a_dtap_pinfo, subtree, curr_offset);      
packet-gsm_a_common.c:                  curr_offset = dissect_e212_mcc_mnc(tvb,
gsm_a_dtap_pinfo, tree, curr_offset);                                           
packet-gsm_a_gm.c:      dissect_e212_mcc_mnc(tvb, gsm_a_dtap_pinfo, subtree,
offset);                         
packet-gsm_a_gm.c:      curr_offset = dissect_e212_mcc_mnc(tvb,
gsm_a_dtap_pinfo, tree, curr_offset);         
packet-gsm_map.c:       dissect_e212_mcc_mnc_in_address(tvb, pinfo, tree, 1);   
packet-gsm_map.c:        dissect_e212_mcc_mnc(parameter_tvb, actx->pinfo,
subtree, 0);                        
packet-gtpv2.c: dissect_e212_mcc_mnc(tvb, pinfo, tree, 0);                      
packet-gtpv2.c:         dissect_e212_mcc_mnc(tvb, pinfo, tree, offset);         
packet-gtpv2.c:         dissect_e212_mcc_mnc(tvb, pinfo, tree, offset);         
packet-gtpv2.c:         dissect_e212_mcc_mnc(tvb, pinfo, tree, offset);         
packet-gtpv2.c:         dissect_e212_mcc_mnc(tvb, pinfo, tree, offset);         
packet-gtpv2.c:         dissect_e212_mcc_mnc(tvb, pinfo, tree, offset);         
packet-nas_eps.c:                       curr_offset = dissect_e212_mcc_mnc(tvb,
gpinfo, tree, curr_offset);   
packet-nas_eps.c:       curr_offset = dissect_e212_mcc_mnc(tvb, gpinfo, tree,
curr_offset);                   
packet-nas_eps.c:                       curr_offset = dissect_e212_mcc_mnc(tvb,
gpinfo, tree, curr_offset);   
packet-nas_eps.c:                       curr_offset = dissect_e212_mcc_mnc(tvb,
gpinfo, tree, curr_offset);   
packet-nas_eps.c:                               curr_offset =
dissect_e212_mcc_mnc(tvb, gpinfo, tree, curr_offset);                           
packet-ranap.c: dissect_e212_mcc_mnc(parameter_tvb, actx->pinfo, tree, 0);      
packet-s1ap.c:  dissect_e212_mcc_mnc(parameter_tvb, actx->pinfo, tree, 0);      
packet-sabp.c:  dissect_e212_mcc_mnc(parameter_tvb, actx->pinfo, subtree, 0);   
packet-sccp.c:          dissect_e212_mcc_mnc_in_address(signals_tvb, pinfo,
digits_tree, 0);                  
packet-uma.c:                   ie_offset = dissect_e212_mcc_mnc(tvb, pinfo,
urr_ie_tree, ie_offset);         
packet-x2ap.c:  dissect_e212_mcc_mnc(parameter_tvb, actx->pinfo, tree, 0);

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.