https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4349
--- Comment #15 from Sake <sake@xxxxxxxxxx> 2010-01-22 15:09:53 PST ---
Hi Adam,
I have reviewed the latest version of your patch. And here are some comments:
- IO channels are not (yet) used within Wireshark, I'm no expert on portability
(which the IO channels seem to be aiming for), but the documentation says:
"Currently full support is available on UNIX platforms, support for Windows is
only partially complete.". I think the use of IO channels should be discussed
on wireshark-dev first
- I'm not a fan of rereading the key-log file for each SSL negotiation in the
tracefile. I would suggest loading the PMS from file when the dissector
initiates, just like it is done for the certificates. It would be nice to have
this "PMS cache" implemented in such a way it can be used to export the keys
too (when decryption was based on a certificate), as a start for implementing
bug 3444.
- Please don't use C++ style comments, Wireshark is using ANSI-C for
portability.
- I've already checked in the "entrypted" spelling error fix :-) (SVN: 31628)
Now that the export function is in NSS, will it be available in the official
Firefox/Chrome releases? Or does a custom debug version must be built?
Cheers,
Sake
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
