Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 4403] Fix return type of hex_view_get_byte()

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4403

Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4152|                            |review_for_checkin?
               Flag|                            |

--- Comment #5 from Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx> 2010-01-19 12:22:03 PST ---
Created an attachment (id=4152)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4152)
Create only one marker in packet_hex_print_common.

Thanks, 

So one more patch :)
It's not memleak, cause memory allocated by gtk_text_buffer_create_mark will be
destroyed when GtkTextBuffer is.

I'm not sure if instead of !mark, user should always be scrolled to main
'item'.
But imho first match is also good.
(and proto_tree_set_appendix() is used quite rare)

(If you want, I have IEE 802.11 frame, with probe request to reproduce the
problem)

Ok to close with this patch.


Btw. I'd really like to cleanup packet_hex_print_common() from reverse,
newreverse logic.. 
I have one patch ready but I have second thoughts if it's good idea or not,
so not yet...

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.