Wireshark-bugs: [Wireshark-bugs] [Bug 4339] [PATCH] VNC dissector cleanups and minor changes
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 10 Jan 2010 04:35:40 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4339

--- Comment #2 from Yaniv Kaul <mykaul@xxxxxxxxx> 2010-01-10 04:35:33 PST ---
(In reply to comment #1)
> Committed: SVN #31464.
> 
> I made a few fixes (as well as some cosmetic changes) to the patch.
> 
> Please review and then close this bug if OK.
> 
> Thanks

It's difficult to see what has changed from my patch without a diff to it, but
generally it looks ok.
I'm not sure what the consequence of the removal of the 2nd
'heur_dissector_add("tcp", test_vnc_protocol, proto_vnc);' line.

I've added it in rev. 28394, can't see the logic why it was added twice (and
why not remove the first call to it).
I'll test to see that there are no regressions.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.