Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3677] new dissector for EtherCAT Switch Link Header added to EtherCAT plugin

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3677

Bill Meier <wmeier@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|wmeier@xxxxxxxxxxx          |

--- Comment #8 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-01-02 14:49:54 PST ---
Richard:

While doing some wotk on the packet-esl.c dissector I noticed that the display
of the crcError and alignError flags might be incorrect. 

The bitmasks as used in the following appear to not match the definitions in
the ??? struct.

        { &hf_esl_crcerror,
          { "Crc Error", "esl.crcerror",
            FT_BOOLEAN, 16, TFS(&flags_yes_no), 0x1000 /* XXX: Should be 0x0800
to match struct definition ?? */,
            NULL, HFILL }
        },
        { &hf_esl_alignerror,
          { "Alignment Error", "esl.alignerror",
            FT_BOOLEAN, 16, TFS(&flags_yes_no), 0x0800 /* xxx: Should be 0x1000
to match struct definition ?? */,
            NULL, HFILL }
        },

There's also some verbiage in the ET2000.chm file downloaded as described in
Comment #7 that seems to indicate that the crcError flag is bit 3 of the
high-order byte of the byte at offset of the header).

Can you comment on this ??

(I'll leave this bug open for the moment to see if an answer can be
obtained....).

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.