https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4244
--- Comment #4 from Aamer Akhter <aakhter@xxxxxxxxx> 2009-11-17 06:46:09 PDT ---
(In reply to comment #1)
> Hi,
> The patch fails
> patching file epan/dissectors/packet-cdp.c
> Hunk #2 FAILED at 309.
> Hunk #3 FAILED at 343.
> Hunk #4 FAILED at 425.
> Hunk #5 FAILED at 1276.
> Please regenerate against trunk.
> Use
> proto_tree_add_item(tlv_tree, hf_cdp_deviceid, tvb, offset + 4, length - 4,
> FALSE);
> instead
Apologies. cut and paste error in between machines.
>
> I don't have a trace to test with but isn't the same line output twice?
> :
> tlvi = proto_tree_add_text(cdp_tree, tvb, offset,
> length, "Device ID: %s",
> tvb_format_stringzpad(tvb, offset + 4,
> length - 4));
> :
> proto_tree_add_text(tlv_tree, tvb, offset + 4,
> length - 4, "Device ID: %s",
> tvb_format_stringzpad(tvb, offset + 4, length -
> 4));
>
Trace has been uploaded. The two items above are actually different parts of
the tree. The first one is the summary line for the TLV, while the second one
is the explicit V field (of the TLV)
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
