https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4235
--- Comment #6 from J.C. Wren <jcwren@xxxxxxxxxx> 2009-11-11 08:34:56 PDT ---
I've dropped the __attribute__'s, even though this makes it more of a nuisance
to move a new copy of the header file over if/when the protocol is updated.
gmodule.h has been removed.
I cannot use the epan/crc algorithm because there's no provision for overriding
the crc16_ccitt_start variable. CCITT starts with a seed of 0xffff,
unfortunately for compatibility reasons with a previous product, R3 starts with
a seed of 0x0000. If a provision is made to override the variable, or if
no-one minds if I add a method, I can convert to that.
val_to_str() does not yield the results I need, nor do any of the other string
matching values. What I need is a method that if no match occurs, a specific
value is returned, namely the last value in the table. match_strstr() looked
like a viable candidate, but returns NULL on no match, which doesn't suit my
needs. I have added DISSECTOR_ASSERTS() to key and ms to protect against NULL
values.
R3 actually IS the name of the protocol. I would not be adverse to renaming to
packet-assa_r3.c. I presume if I do, you'd like me to rename the 'r3'
directory to 'assa-r3' and update the affected files? I'd like to keep the
short name to 'r3', since that's what our customers know it as. I can be
swayed, but I feel the name is no less cryptic than the majority of others.
I'm in the process of converting it to a built-in, but I thought I'd wait for
any responses before attaching a new diff file.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
