Wireshark-bugs: [Wireshark-bugs] [Bug 4235] Addition of Assa Abloy R3 protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 10 Nov 2009 14:16:22 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4235





--- Comment #1 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2009-11-10 14:16:21 PDT ---
Quick review:
Please convert into regular dissector, no need to keep as plugin.
Drop GCC'isms, like __attribute__
Don't include gmodule.h
CRC (ccitt16) calculation is available in epan/crc/
Why these TCP ports? port 2571 is assigned to another protocol:
cecsvc          2571/tcp   CECSVC
value_string must end in {0, NULL}
please use val_to_str() instead of your own r3_matchstring()

Have you fuzztested this code!? Can you provide sample captures?


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.