Wireshark-bugs: [Wireshark-bugs] [Bug 4217] Integer overflow in ZBEE zdp discovery dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 9 Nov 2009 08:57:46 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4217


Gerald Combs <gerald@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gerald@xxxxxxxxxxxxx




--- Comment #3 from Gerald Combs <gerald@xxxxxxxxxxxxx>  2009-11-09 08:57:45 PDT ---
hf_zbee_zdp_user is an FT_STRING. Couldn't 

--------
    user        = ep_alloc(user_length+1);
    user        = tvb_memcpy(tvb, user, offset, user_length);
    user[user_length] = '\0';
    if (tree) {
        proto_tree_add_string(tree, hf_zbee_zdp_user, tvb, offset, user_length,
user);
    }
--------

be simplified to

--------
    if (tree) {
        proto_tree_add_item(tree, hf_zbee_zdp_user, tvb, offset, user_length,
user);
    }
--------

?


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.