Wireshark-bugs: [Wireshark-bugs] [Bug 4119] Wireshark crashes w/ GLib error when trying to play
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4119
--- Comment #3 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2009-10-24 04:29:20 PDT ---
(In reply to comment #2)
> Another detail: because RTP timestamps are being used, the "exceeded jitter
> buffer" check in gtk/rtp_player.c is skipped. But, inside of that check is a
> "if there was a silence period of more than 2 packetization periods then
> resync". In this case I suspect we /should/ be resync'ing. Should this 'if'
> be moved outside the jiffer-buffer 'if'?
Hmm, sounds reasonable. If I can find the time I'll try to look into this...
> One last question (in case anyone knows): in this code (in decode_rtp_stream())
> there are 2 places where silence frames are added but the silence audio is only
> added in the 2nd case. Is that correct?
That all depends. Again a good point of attention for hardening the RTP player.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
