https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4073
Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jeff.morriss.ws@xxxxxxxxx
--- Comment #2 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2009-10-02 06:52:05 PDT ---
This isn't portable:
+static const aim_client_capability *aim_find_short_capability(guint16 shortid)
+{
+ const e_uuid_t clsid = { 0x09460000|shortid, 0x4c7f, 0x11d1, {0x82,
0x22, 0x44, 0x45, 0x53, 0x54, 0x00, 0x00 }};
at least according to the Portability section of README.developer:
> Don't initialize variables in their declaration with non-constant
> values. Not all compilers support this. E.g. don't use
Adding this field as a text item:
+ proto_tree_add_text(entry, tvb, offset, 2,
+ "%s (0x%04x)",
+ caps?caps->name:"Unknown", shortid
means that it will not be filterable--that's usually a bad thing (there already
too many add_text()s in this dissector, we shouldn't add more). Could you
change that to use one of the proto_tree_add_string*() functions (with an hf_
entry)? (Unless there is a good reason not to make this field filterable.)
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
