Wireshark-bugs: [Wireshark-bugs] [Bug 3984] r29723 optimization, if (cinfo->col_data[col] != cin
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3984
--- Comment #9 from didier gautheron <dgautheron@xxxxxxxx> 2009-09-24 17:14:14 PDT ---
(In reply to comment #7)
> We should fix these issues instead of trying to hide them. Things like these
> only get worse with time.
A lot of dissectors are not in SVN and their authors often don't know all
wireshark 'quirks', with val_str the problem may appear very rarely and for
them fixing this bug will waste more time than they ever win by saving a little
memory.
>
> > Moreover a lot of dissectors currently using col_add_str(..., val_to_str(...))
> > could be move back to use col_set_str.
> > It would save more memory, unknown values are or should be uncommon, and it
> > would be faster.
>
> Are you proposing that we keep both col_set_str and col_add_str while still
> allowing col_set_str to be called with an ep_alloc'ed string?
>
Yes cf. attached patch.
Note: some dissectors set COL_DEF_SRC with col_add_str or col_add_fstr so I
remove the whole switch.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
