Wireshark-bugs: [Wireshark-bugs] [Bug 4014] ICMP: Add ID and seq # to Info column
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 23 Sep 2009 05:39:42 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4014





--- Comment #6 from Chris Maynard <christopher.maynard@xxxxxxxxx>  2009-09-23 05:39:40 PDT ---
(In reply to comment #5)
> Is this change really necessary?
> 
> -  col_set_str(pinfo->cinfo, COL_INFO, type_str);
> +  col_add_fstr(pinfo->cinfo, COL_INFO, "%-20s", type_str);
> 

It's only there to keep the ID's and Seq #'s aligned in the same column.  I
find it easier to scan down the packets looking for matching seq #'s if I can
stare at one column all the way down rather than moving my eyes back and forth
as well as down.  The value of 20 was chosen for the alignment since it's the
length of the longest ICMP type string for all types that carry the ID and Seq
#, namely this one:
  { ICMP_MASKREQ,      "Address mask request" },

So to answer your question, "Is it really necessary?"  Nope.  Personally I like
it better though.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.