Wireshark-bugs: [Wireshark-bugs] [Bug 4026] New Packet Dissector - jmirror
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 17 Sep 2009 23:13:28 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4026





--- Comment #1 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2009-09-17 23:13:25 PDT ---
Quick review of the dissector.
hexVal() has to go. Wireshark provides all the stuff you need.
val = hexVal() needs to be replaces by tvb_get_ntohl().
(check_col(pinfo->cinfo, COL_...)) checks are not required anymore.
Don't proto_tree_add_text() and then try to add the value as a hidden filter.
Setup the proper header fields and let Wireshark do the work calling
proto_tree_add_item().
You try to do encapsulated packet type detection yourself, why not kickback the
new_tvb to the frame dissector?
The header fields: These are not FT_UINT8, they're FT_UINT32. Also make the
Blurbs NULL i.s.o. a random example.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.