Wireshark-bugs: [Wireshark-bugs] [Bug 3856] The Shomiti wireless format has been modified
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 16 Sep 2009 20:10:49 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3856





--- Comment #8 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>  2009-09-16 20:10:48 PDT ---
(In reply to comment #7)
>     2) not skip the rest of the header by reading into a fixed-length buffer,
> as there's no absolute 100% guarantee that the header length won't be greater
> than 8 + the buffer length;

I had thought of that possibility before checking it in and decided it was safe
since rsize is set to the value of a U8 (read from the header) minus 8 (so:
maximum 247) and the buffer was 250 bytes.  BUT: you're right that using seek
is a much better idea.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.