Wireshark-bugs: [Wireshark-bugs] [Bug 3970] New Dissector Plugin: CAPWAP Dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3970
Jaap Keuter <jaap.keuter@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|High |Medium
--- Comment #2 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2009-09-01 06:28:46 PDT ---
just a quick review:
- drop the config.nmake changes
- don't like the epan/dissectors/packet-ssl-utils.c change
- might as well make it a build in dissector
- drop plugins/capwap/capwap.rc
- drop plugins/capwap/plugin.c
- all your value_string's need to end with {0, NULL}
- code like this:
+ tvb_memcpy(tvb, (guint8*) &numStations, offset, 2);
+ numStations = g_ntohs(numStations);
+ proto_tree_add_uint(capwap_tree_msgEle,
hf_capwap_msgelement_ACDesc_numStations,
+ tvb, offset, 2, numStations);
has to be changed into code like this:
+ proto_tree_add_item(capwap_tree_msgEle,
hf_capwap_msgelement_ACDesc_numStations,
+ tvb, offset, 2, FALSE);
- C++ style comment have to go
- g_malloc must be removed or replaced by se_alloc/ep_alloc and friends
- preference changes aren't processed until restart. Provide a function for
that or tailor proto_reg_handoff_capwap() for the job.
- replace "" blurbs in header fields with NULL
- typecheck header fields. fi. FT_BYTES are not BASE_HEX
- clean up indentation
- remove checks like "if (check_col(pinfo->cinfo, COL_PROTOCOL))"
- FUZZ TEST YOUR DISSECTOR
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
