Wireshark-bugs: [Wireshark-bugs] [Bug 3870] support for more DNS RRs for packet-dns.c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 19 Aug 2009 08:34:03 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3870





--- Comment #10 from Ivan Sy <ivan_jr@xxxxxxxxx>  2009-08-19 08:34:01 PDT ---
Thanks for the review...

I'll clean up the  if (cinfo != NULL)  however, I noticed that it is common to
almost all of the DNS types from T_A to the previous patches that i've
submitted like T_HIP and T_DHCID. should i take it off from the other types?

I've also read your comment#11 of bug#2902
" ...just like was done for the proto_tree_add_xxx(tree, ...) where the check
for  tree!=NULL was made obsolete by adding it to the API ... "

should I also remove if (dns_tree != NULL) as well?

im also thinking of supporting the older rfc 1035 DNS RRs.. to make the DNS
dissector completely understand all RFC-based DNS RRs. should it be better to
support non-RFC DNS RR types? http://www.iana.org/assignments/dns-parameters

im planning to submit two patches
- clean up of dns dissector based on your comments
- additional dns rr types (the ones above and rfc1035)

thanks!


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.