Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3917] New: tvb_new_real_data is prone to memory leak.

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3917

           Summary: tvb_new_real_data is prone to memory leak.
           Product: Wireshark
           Version: SVN
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: dgautheron@xxxxxxxx


Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
Hi,

following files still use tvb_new_real_data
./asn1/pkcs12/packet-pkcs12-template.c
leak memory, clear_tvb is never freed or attached to a parent tvb.

./asn1/kerberos/packet-kerberos-template.c
may leak memory, not all code paths call tvb_free(encr_tvb).

./epan/dissectors/packet-dcp-etsi.c
surely leak tvb structure memory.

./epan/dissectors/packet-cip.c
./epan/dissectors/packet-giop.c
Ok.

./epan/dissectors/packet-ssl-utils.c
leak tvb structure memory.

./epan/dissectors/packet-nfs.c
leak tvb structure memory.

./epan/dissectors/pidl/mapi/request.cnf.c
./epan/dissectors/pidl/mapi/response.cnf.c
ok but should use tvb_new_child_real_data().

./epan/dissectors/packet-rtmpt.c
may leak memory, anyway it uses tvb_composite_append() so it surely broken.

./epan/dissectors/packet-syslog.c
leak memory.

./epan/packet.c
./epan/ftypes/ftype-tvbuff.c
./epan/wslua/wslua_tvb.c
Ok.

./plugins/asn1/packet-asn1.c
leak and dissect a tvb buff in proto_reg_handoff() outside a TRY block.

./epan/tvbuff.c
ok but
./epan/dissectors/packet-dmp.c and ./epan/dissectors/packet-ldss.c use 
tvb_uncompress and leak memory, should use tvb_child_uncompress


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.