Wireshark-bugs: [Wireshark-bugs] [Bug 3816] TShark and fuzz-test do not detect dissector asserts
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 7 Aug 2009 09:42:31 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3816


Bill Meier <wmeier@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #1 from Bill Meier <wmeier@xxxxxxxxxxx>  2009-08-07 09:42:28 PDT ---
(In reply to comment #0)

> --
> TShark and fuzz-test.sh don't detect dissector asserts.
> 
> The reason is that TShark shows nothing when a dissector assert fails
> (DISSECTOR_ASSERT). It should show a similar text as Wireshark does:
> 
> 09:33:13          Warn Dissector bug, protocol 104asdu, in packet 917:
> packet-iec104.c:1109: failed assertion "..."
> 
> 'fuzz-test.sh' uses TShark and searches for 'dissector bug' in the output. So,
> if TShark is fixed, fuzz-test will detect dissector asserts.
> 


Good catch !!

tshark does output the "Dissector bug" messages on *stdout* as part of the
normal output.

However fuzz-test is searching the tshark *stderr* output for the "dissector
bug" messages. Obviously none will be found.

I'll dig into this a bit more and see what I can do for a fix.

Thanks ...


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.