Wireshark-bugs: [Wireshark-bugs] [Bug 3556] New: The title in the TCP sequence graphs is too sho
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 19 Jun 2009 19:51:49 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3556

           Summary: The title in the TCP sequence graphs is too short
           Product: Wireshark
           Version: 1.2.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: sean@xxxxxxxx


Created an attachment (id=3154)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3154)
patch

Build Information:
[sean@bob wireshark]$ ./wireshark -v
wireshark 1.2.0 (SVN Rev 28753)

Copyright 1998-2009 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.12.12, with GLib 2.16.6, with libpcap 0.9.8, with libz
1.2.3, with POSIX capabilities (Linux), with libpcre 7.3, without SMI, without
c-ares, without ADNS, with Lua 5.1, with GnuTLS 2.0.4, with Gcrypt 1.4.4, with
MIT Kerberos, without GeoIP, without PortAudio, without AirPcap.

Running on Linux 2.6.27.21-78.2.41.fc9.i686, with libpcap version 0.9.8, GnuTLS
2.0.4, Gcrypt 1.4.4.

Built using gcc 4.3.0 20080428 (Red Hat 4.3.0-8).

--
The title in the TCP sequence graph windows can only be 64 characters long. The
title includes, in order,

TCP Graph %d 
Display name (capture or file name)
Source IP:Port -> Dest IP:Port

If the display name is more than 15 or so characters you end up with the IP
address being truncated, which makes it more difficult to figure out what's
going on.

This seems to affect all 1.0 and 1.2 versions on all platforms.

It would seem that no matter how big you make the title, GTK takes care of
truncating as necessary. Therefore, I propose increasing the current char[64]
to char[256].

A patch against 1.2 is attached. Note that the #define was made twice in the
file for the two separate windows, I moved the definition to the top of the
file.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.