Wireshark-bugs: [Wireshark-bugs] [Bug 3548] Cleanup header_field_info definitions
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548
Kovarththanan Rajaratnam <krj@xxxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3147| |review_for_checkin?
Flag| |
--- Comment #12 from Kovarththanan Rajaratnam <krj@xxxxxxxxxxxxx> 2009-06-19 02:13:35 PDT ---
Created an attachment (id=3147)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3147)
Cleanup asn1/ header field info templates files
Thanks for pointing that out :) I can seem to get the asn1 stuff compiling
(even without my patch), so I haven't been able to test my fix. Beware!
Also note that the patch contains this chunk which seems suspicious. The
original line contains DISPLAY = NONE. Shouldn't it be BASE_NONE as my fix
suggests? Perhaps the parser is robust enough to handle the missing BASE_
prefix?
@@ -635,8 +635,8 @@ proto_tree *subtree;
#.TYPE_ATTR
PDPTypeOrganization TYPE = FT_UINT8 DISPLAY = BASE_DEC BITMASK = 0x0f
STRINGS = VALS(gsm_map_PDP_Type_Organisation_vals)
-DateAndTime TYPE = FT_STRING DISPLAY = NONE
-AccessPointName TYPE = FT_STRING DISPLAY = NONE
+DateAndTime TYPE = FT_STRING DISPLAY = BASE_NONE
+AccessPointName TYPE = FT_STRING DISPLAY = BASE_NONE
Code/local TYPE = FT_INT32 DISPLAY = BASE_DEC STRINGS =
VALS(camel_opr_code_strings)
ServiceInteractionIndicatorsTwo/holdTreatmentIndicator TYPE = FT_INT32
DISPLAY = BASE_DEC STRINGS = VALS(camel_holdTreatmentIndicator_values)
ServiceInteractionIndicatorsTwo/cwTreatmentIndicator TYPE = FT_INT32 DISPLAY
= BASE_DEC STRINGS = VALS(camel_cwTreatmentIndicator_values)
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
