Wireshark-bugs: [Wireshark-bugs] [Bug 3508] so lag when typing backspace key on display filter
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3508
--- Comment #3 from Lunxian <lunxian@xxxxxxxxx> 2009-06-06 12:41:19 PDT ---
I read the source code, and it seems that the "Sort treeview" is the core to
consume performance of input "radius.", is it?
The code is in function filter_autocomplete_new of filter_autocomplete.c :
/* Sort treeview */
model = gtk_tree_view_get_model(GTK_TREE_VIEW(treeview));
order = GTK_SORT_ASCENDING;
if(model)
gtk_tree_sortable_set_sort_column_id(GTK_TREE_SORTABLE(model), 0, order);
backspacing performance is not same as inputing "radius." directly, I will
review the function filter_autocomplete_handle_backspace(), no problem found.
Maybe "Empty list" is poor performance?
/* Empty list */
store = GTK_LIST_STORE(gtk_tree_view_get_model(GTK_TREE_VIEW(list)));
gtk_list_store_clear(store);
> The performance should be optimized.
>
> I think the population algorithm of auto-hint list should be review to improve
> performance. Cache auto-hint list maybe is a proper way.
> And the backspacing to a dotpopulation performance is degraded 3 times than
> auto-hinting directly after a dot, why?
>
> I'm not familiar with wireshark code base. Someone will tell me the auto-hint
> codes? I want to read code to give more help.
>
> > This delay is due to the fact that the auto-hint list has to be populated with
> > all possible entries, somewhat of a long list for radius. It's a performance
> > problem somewhere.
> >
>
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
