Wireshark-bugs: [Wireshark-bugs] [Bug 3474] Compilation error in gtk/dfilter_expr_dlg.c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 25 May 2009 11:42:57 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3474


Guy Harris <guy@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Guy Harris <guy@xxxxxxxxxxxx>  2009-05-25 11:42:56 PDT ---
g_assert_not_reached() never returns, so it's irrelevant whether
gtk_entry_set_text() or g_free() can handle being passed a null pointer - that
won't happen (modulo somebody catching SIGABRT or something silly such as
that).

Presumably newer versions of gcc realize that g_assert_not_reached() never
returns and therefore realize that, in all code paths that can actually make it
to the end of the function, value_string is set.

Checked in (without the comment).


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.