Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3431] Dissector suite for ZigBee protocol stack

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3431


Gerald Combs <gerald@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Gerald Combs <gerald@xxxxxxxxxxxxx>  2009-05-20 12:31:21 PDT ---
Checked in in r28429 after running 500 fuzz passes with the decryption key
applied, and after fixing a pile of gcc errors and warnings, e.g.

cc1: warnings being treated as errors
packet-zbee-aps.c: In function 'dissect_zbee_aps':
packet-zbee-aps.c:340: warning: format not a string literal and no format
arguments
packet-zbee-aps.c:600: warning: statement with no effect
packet-zbee-aps.c:593: warning: unused variable 'save_fragmented'
packet-zbee-aps.c: In function 'dissect_zbee_aps_skke_challenge':
packet-zbee-aps.c:823: warning: unused parameter 'pinfo'
packet-zbee-aps.c: In function 'dissect_zbee_aps_skke_data':
packet-zbee-aps.c:869: warning: unused parameter 'pinfo'
packet-zbee-aps.c: In function 'dissect_zbee_aps_transport_key':
packet-zbee-aps.c:916: warning: unused parameter 'pinfo'
packet-zbee-aps.c: In function 'dissect_zbee_aps_remove_device':
packet-zbee-aps.c:1090: warning: unused parameter 'pinfo'
packet-zbee-aps.c: In function 'dissect_zbee_aps_request_key':
packet-zbee-aps.c:1120: warning: unused parameter 'pinfo'
packet-zbee-aps.c: In function 'dissect_zbee_aps_switch_key':
packet-zbee-aps.c:1160: warning: unused parameter 'pinfo'
packet-zbee-aps.c: In function 'dissect_zbee_aps_auth_challenge':
packet-zbee-aps.c:1191: warning: unused parameter 'pinfo'
packet-zbee-aps.c: In function 'dissect_zbee_aps_auth_data':
packet-zbee-aps.c:1255: warning: unused parameter 'pinfo'

You might want to review the changes to make sure they're correct. In
particular my fix for:

packet-zbee-security.c: In function 'zbee_sec_ccm_decrypt':
packet-zbee-security.c:800: warning: operation on 'j' may be undefined
packet-zbee-security.c:801: warning: operation on 'j' may be undefined

and my use of tvb_get_ephemeral_string() in dissect_zbee_zdp_rsp_user_desc().


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.