Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3473] VLAN dissector passes FCS to sub-dissectors

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3473


Artem Tamazov <artem.tamazov@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3015|                            |review_for_checkin?
               Flag|                            |




--- Comment #1 from Artem Tamazov <artem.tamazov@xxxxxxxxxxx>  2009-05-20 08:03:51 PDT ---
Created an attachment (id=3015)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3015)
vlan-fcs-options-svn28421.patch

This patch adds couple of options to VLAN dissector:
- "Assume packets have FCS" which removes last 4 bytes from tvb passed to
sub-dissectors (and decodes these as FCS);
- "Consider FCS as a part of trailer" which toggles off FCS check. Otherwise,
FCS usually displayed as "incorrect value". Perhaps this is because capturing
of FCS values is not supported in most cases (and dummy data used instead of
valid FCS).

Normally both options should be enabled.This allows normal work for
sub-dissectors which unable to deduce amount of data to be dissected, like
SAToP or MPLS PW ATM.

If compatibility with older versions is required, first option should be
disabled.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.