Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3467] Memcache Textual Protocol dissector patch

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3467





--- Comment #13 from Rama Chitta <rama@xxxxxxxxx>  2009-05-19 11:50:46 PDT ---
(In reply to comment #6)
> Created an attachment (id=3007)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3007) [details]
> Memcache text protocol - take 2
> 
> Somewhat cleanup of the previous patch.
> 


Thanks a bunch for fixing all the gotos logic for me. Looks perfect. thanks. I
tried to apply the patch and it failed. Just looked at how far the patch was
successful and noticed that you fixed all the gotos logic in the file.
Appreciate it.

my patch reject file: epan/dissector/packet-memcache.c.rej

***************
*** 1,9 ****
  /* packet-memcache.c
   * Routines for Memcache Binary Protocol
   * http://code.google.com/p/memcached/wiki/MemcacheBinaryProtocol
   *
   * Copyright 2009, Stig Bjorlykke <stig@xxxxxxxxxxxxx>
   *
   * $Id$
   *
   * Wireshark - Network traffic analyzer
--- 1,15 ----
  /* packet-memcache.c
+  *
   * Routines for Memcache Binary Protocol
   * http://code.google.com/p/memcached/wiki/MemcacheBinaryProtocol
   *
   * Copyright 2009, Stig Bjorlykke <stig@xxxxxxxxxxxxx>
   *
+  * Routines for Memcache Textual Protocol
+  * http://code.sixapart.com/svn/memcached/trunk/server/doc/protocol.txt
+  *
+  * Copyright 2009, Rama Chitta <rama@xxxxxxxxx>
+  *
   * $Id$
   *
   * Wireshark - Network traffic analyzer


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.