Wireshark-bugs: [Wireshark-bugs] [Bug 3378] New Dissector: Host Identity Protocol
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3378
--- Comment #7 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2009-05-19 00:30:21 PDT ---
Quick review:
- value_strings must be {0, NULL} terminated.
- Move variables and function prototypes from header to source file and make
these static to avoid namespace polution.
- Use the WS provided value to string mapping functions (i.s.o. functions like
hip_param and others)
- It looks like hip_transform is used as a state variable. That cannot be done
like this (module static) because you cannot know how the packets are passed to
your dissector.
- FT_BYTES are always BASE_NONE
- "", HFILL -> NULL, HFILL
- don't extract the value with an access function as a proto_tree_add
parameter, use the generic _add_item:
Replace:
proto_tree_add_uint(t, hf_hip_tlv_locator_spi, tvb, newoffset, 4,
tvb_get_ntohl(tvb, newoffset));
By:
proto_tree_add_item(t, hf_hip_tlv_locator_spi, tvb, newoffset, 4, TRUE);
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
