https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3256
--- Comment #3 from Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx> 2009-03-01 15:53:46 PDT ---
You're almost there. I have a few comments about things that need to be
addressed before we can include this protocol in Wireshark:
- Remove the #if 1 / #endif block toward the top of packet-gg.c
- Remove any printf() statements as dissectors should not be printing anything
to the console unless it is being debugged
- A number of functions say "XXX, make it better" - make what better exactly?
- If an argument to a function is not used, don't set it equal to itself in the
function to squelch the compiler warning. Instead, put _U_ after it like this:
dissect_gg_common_status4(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree
*tree ...
_U_ expands to __attribute__((unused)) in GCC (per our command line option
-D_U_=...), which is the only compiler where we have warnings turned into
errors for not using an argument.
Please submit a new patch with the comments above addressed. Thanks!
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
