Wireshark-bugs: [Wireshark-bugs] [Bug 3009] new ismacryp dissector
Date: Fri, 20 Feb 2009 02:50:54 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3009





--- Comment #7 from David Castleford <david.castleford@xxxxxxxxxxxxxxxxxx>  2009-02-20 02:50:51 PDT ---
(In reply to comment #2)
> I've done a quick first review (mostly looking at the proto_register and
> proto_reg_handoff code). There's one or two small changes in this code which
> are desirable and which I'l take care of.
>

Great, thanks.

> However, After I build the dissector (as attached in your patch without any
> changes) Wireshark loops and then eventually dies dissecting your capture file
> attached.
> 
> Specifically: the dissector seems to go into a loop in the following code when
> processing the first packet.
> 
> while((totalbits-8*AU_HEADERS_LENGTH_SIZE)<au_headers_length) /* subtract AU
> headers length bits*/
>         {
>         poffset=dissect_auheader( tvb, poffset, pinfo, ismacryp_tree);
>         totalbits=(poffset->offset_bytes*8)+poffset->offset_bits;       
>         }
> 
Thanks for the info, caught the bug too. Fixed in new patch.

> 
> Note that I set the rtp preference to "use heuristic outside of a conversation"
> and the ismacryp dynamic payload type to 97.
>
Not a problem. 
> 
> Could you please test and determine the nature of the problem.
> 
> (Or: let me know if I'm setting the prefs incorrectly or something).
> 
> 
> Thanks
> 


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.