Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3243] New: Enhancements for CCSDS Dissectors

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3243

           Summary: Enhancements for CCSDS Dissectors
           Product: Wireshark
           Version: SVN
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: Enhancement
          Priority: Medium
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: alex.baldwin@xxxxxxxx



Patrick A Baldwin <alex.baldwin@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2730|                            |review_for_checkin?
               Flag|                            |


Created an attachment (id=2730)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2730)
Patch File containing enhancements to CCSDS dissectors

Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
Updated CCSDS Dissector and added VCDU and EHS Header Dissection.
This patch includes enhancements to CCSDS protocols.
CCSDS VCDU Header Dissection, CCSDS Primary and Secondary Headers as well as
SMEX and EHS Headers.

This release has been fuzz tested.

Original release by Scott Hovis, enhanced by Matt Dunkle, testing and patch
generation by Patrick A Baldwin
(256) 544 2089
alex.baldwin@xxxxxxxx

In addition, we believe that we have addressed all of the following comments
from the first contribution:
>Quick review:
>We've been Wireshark for some time now. Please don't roll back to the Ethereal
>days.
>We no longer depend on our own snprintf, so don't try to include that.
>What's wrong with using GLib or libc provided time conversion functions? 
>proto_register_ccsds() is not the place to setup value_string's, this is
>normally done at module level.
>value_string's are never directly included in header fields, they are to be
>wrapped in VALS() macro.
>Header fields with type FT_BOOLEAN use the 'display' field to set the width of
>the parent bitfield (ref. README.developer). Do not change such sizes into
>BASE_* values.
>If header field 'names and 'blurb' fields are the same, fill 'blurb' with NULL.

However, one issue the time format.

It was requested in the previous comment to use the GlibC functions to format
the time.  However none of the glibc functions can format the time in precisely
the manner that we use for these protocols, so we format it in the software,
simply to conform to the HOSC standard.

For those interested, documentation of these protocols can be found at:

> Try this one for most of the protocols which are public:
>
> SSP 50305
> https://upn.ums.msfc.nasa.gov/sites/ice/docrepository/Remote%20HOSC%20
> Documents/50305D.pdf
However it is required to create a UserID and password.  Questions or comments
can be directed to:
Patrick A Baldwin
(256) 544 2089
alex.baldwin@xxxxxxxx


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.