Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3170] New plugin to dissect collectd network packets

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3170


Florian Forster <wireshark.org@xxxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2663|review_for_checkin?         |
               Flag|                            |
Attachment #2663 is|0                           |1
           obsolete|                            |
   Attachment #2711|                            |review_for_checkin?
               Flag|                            |




--- Comment #14 from Florian Forster <wireshark.org@xxxxxxxxxxxxxxxxxxx>  2009-01-30 14:47:12 PDT ---
Created an attachment (id=2711)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2711)
Revised patch against revision 27332.

Hi,

thanks for you feedback Jaap :) I hope to address your concerns in this updated
patch:

 - The dissect_time_format() function has been removed altogether and was
replaced by a call to abs_time_secs_to_str().
 - The proto_register_collectd() function has been moved up before/above the
proto_reg_handoff_collectd() function. Since the former calls the latter I
rearranged the functions to get around the prototype; didn't expect that to be
a problem.
 - The extra if-block in proto_reg_handoff_collectd() has been removed.

Sorry, but I don't know what you mean by ``TLV handling''. If there's anything
else I should change, please let me know.

Regards,
-octo


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.