Wireshark-bugs: [Wireshark-bugs] [Bug 3190] Allow custom Bootp/DHCP option decodes
Date: Mon, 12 Jan 2009 17:05:17 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3190


Jörg Mayer <jmayer@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jmayer@xxxxxxxxx




--- Comment #1 from Jörg Mayer <jmayer@xxxxxxxxx>  2009-01-12 17:05:15 PDT ---
While the code is rather hacky, I like the idea that it contains very much!!

One thing to do would be to use prefs_register_uat_preference (see
packet-snmp.c) for an example on how to use it). This of course will require
the code to undo changes that were done to the table if a line is removed from
the prefs table. Another would be to add all types that can be used in that
context. Third wish would be better input checking, e.g. the code using
"optiondetail[2]" doesn't make sure that this value exists, which might happen
in case someone enters only a value without or with only a  single ','. 

PS: While I really like this idea, please don't give up on your patch for bug
3171 :-) If you want/need help with any of these patches just let us know.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.