Wireshark-bugs: [Wireshark-bugs] [Bug 3165] LDP PW switching point TLV support
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 7 Jan 2009 21:39:41 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3165





--- Comment #5 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2009-01-07 21:39:40 PDT ---
(In reply to comment #3)
Thanks for addressing all these items.

> >Why all these complicated proto_tree_add_xxx calls? The header fields are setup
> >already, why not just call proto_tree_add_item()?
> 
> I wanted to make it easy for someone else to add support for the other (more
> complex) field types. For types 1-4 it would have been simpler to just add the
> items which was the point of your comment, I think. Nothing changed.

Can you do that anyway? That makes the code so much easier to read, and
therefore to extend by someone else.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.