Wireshark-bugs: [Wireshark-bugs] [Bug 3170] New plugin to dissect collectd network packets
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 4 Jan 2009 05:54:15 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3170





--- Comment #3 from Bruno <bonbons67@xxxxxxxxxxx>  2009-01-04 05:54:15 PDT ---
(In reply to comment #1)
> That is a whole lot of compiler foo in there: _ISOC99_SOURCE,
> detect_double_need_endianflip(), stuff like that. Why can't tvb_get_letoh64()
> do the work for you?
For the endian flipping tvb_get_letoh64() may probably work.

Regarding _ISOC99_SOURCE, it is needed to get NAN defined...
What is the best option to have NAN defined without using _ISOC99_SOURCE?
The rest of that part is all to consider doubles the same way as collectd does
(collectd uses x86 doubles in it's network protocol).

If there is a clean way to convert x86 doubles to host-double I would use it,
though for now I know of none...

> You may also want to make use of the 'plurality' macro.
Ok, will use it

> If possible please create a patch against the development trunk, since this
> code won't be added to the stable branch.
Next patch will be against trunk


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.