Wireshark-bugs: [Wireshark-bugs] [Bug 3171] Enhancement of packet-bootp.c to the decode of optio
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 3 Jan 2009 15:54:16 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3171





--- Comment #1 from Jörg Mayer <jmayer@xxxxxxxxx>  2009-01-03 15:54:15 PDT ---
I'd like to see a few changes before this patch goes in:

1) There is no need to add a preferences option to turn on the Avaya option
decoding: You should be able to determine this dynamically by having a look at
the vendorid and deocde the options if the appropriate vid is present

2) There's no need to add a comment about the author of (most) new lines - this
is documented in the svn changelog - but make the appropriate addition to the
AUTHORS file instead.

3) Please provide a sample trace so we may have a look at the results.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.