Wireshark-bugs: [Wireshark-bugs] [Bug 3161] text2pcap.c define trickery breaks strdup() handling
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 27 Dec 2008 02:29:43 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3161





--- Comment #5 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2008-12-27 02:29:42 PDT ---
That is the fun of cross platform applications, you have got to be sure that
changes like this work on *all* platforms. 

The relevant commits are in two groups: 4624, 4629, 4630 and 24044, 25426. The
current define of _XOPEN_SOURCE came in with 24044 (from bug 2183). Together
with the referenced thread I think we should be careful with Solaris / HP-UX
etc.
I would suggest going with 
 #ifndef _XOPEN_SOURCE
-#  define _XOPEN_SOURCE
+#  define _XOPEN_SOURCE 500
 #endif
first and see how much we can wean off further. (Note: using 500 here, not 600,
as that is enough according to the strdup man page, without opening up the C99
can-o-worms). Also influenced are epan/ftypes/ftype-time.c and editcap.c.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.