Wireshark-bugs: [Wireshark-bugs] [Bug 3117] Improvements for the ASAP and ENRP dissectors
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 13 Dec 2008 05:49:35 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3117





--- Comment #2 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2008-12-13 05:49:35 PDT ---
Quick review:

+    pi = proto_tree_add_item(parameter_tree, ....
+    proto_item_append_text(pi, " (%1.2f%%)"  ......
You can do that with proto_tree_add_float_format_value() in one go.

-      proto_tree_add_item(parameter_tree, hf_policy_value, parameter_tvb,
POLICY_VALUE_OFFSET, length, NETWORK_BYTE_ORDER);
+      proto_tree_add_bytes(parameter_tree, hf_policy_value, parameter_tvb,
POLICY_VALUE_OFFSET, length,
+                           tvb_get_ptr(parameter_tvb, POLICY_VALUE_OFFSET,
length));
This shouldn't be needed when hf_policy_value is of FT_BYTES and length is the
correct value.

FT_BYTES don't have BASE_HEX, they have BASE_NONE.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.